chore: reduce fs-extra usage in scripts/
#56917
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tests Passed |
Stats from current PRDefault BuildGeneral
Client Bundles (main, webpack)
Legacy Client Bundles (polyfills)
Client Pages
Client Build Manifests
Rendered Page Sizes
Edge SSR bundle Size
Middleware size
|
SukkaW
requested review from
timneutkens,
ijjk,
shuding,
huozhi,
feedthejim,
ztanner and
wyattjoh
as code owners
styfle
reviewed
Oct 17, 2023
| @@ -1,7 +1,8 @@ | |||
| import os from 'os' | |||
| import path from 'path' | |||
| import execa from 'execa' | |||
| import fs from 'fs-extra' | |||
| import fs from 'fs' | |||
There was a problem hiding this comment.
Can we use promises here instead of sync funcs?
There was a problem hiding this comment.
Even with promises-based fs APIs, the main thread is still blocked by await in the single-threaded script, effectively idling (install-native.mjs is a single-thread script, invoked by pnpm run).
fs async APIs are favored when the main thread should not be blocked, such as a web server managing several incoming requests, or using Promise.all to parallelize tasks sent in the Node.js's libuv worker pool. But we are not doing those in install-native.mjs.
Generally, fs sync APIs are faster (up to 40%) than async APIs (They don't require creating Promise objects, which alleviates GC pressure and avoids extra ticks).
styfle
reviewed
Oct 17, 2023
styfle
reviewed
Oct 17, 2023
styfle
approved these changes
Oct 17, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR follows #56536 and #56491, replacing
fs-extrausages inside thescripts/folder.Note that the
copyandhaven't been replaced yet. Currently, there is no better recursive copy (lightweight, promise-based, Node.js built-inmovecopyFileAPI-based, support thefilteroption) library alternative available on npm,and Node.js built-in.fs.renamedoesn't supportoverwriteThe PR also replaces many async fs API usage with their sync versions.
cc @wbinnssmith